Skip sessions with missing interpreters #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Sep 24, 2018
nox/virtualenv.py
Outdated
| @@ -31,6 +31,12 @@ | |||
| _SYSTEM = platform.system() | |||
|
|
|||
|
|
|||
| class InterpreterNotFound(EnvironmentError): | |||
There was a problem hiding this comment.
$ python2.7 -c 'print(EnvironmentError)'
<type 'exceptions.EnvironmentError'>
$ python3.7 -c 'print(EnvironmentError)'
<class 'OSError'>
There was a problem hiding this comment.
Fixed, good catch. (OSError is fine, but let's use the non-deprecated name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This changes Nox's behavior. Previously, missing interpreters would cause a failed session. Now they just cause a warning. The previous behavior can be used via
--error-on-missing-interpreters.Replaces #138
Closes #136
Releated #93