Warn when programs not in the virtualenv are used, allow erroring and silencing the warning. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… silencing the warning. Add --warn-on-external-run flag and the "external" keyword arg to session.run.
|
@dhermes you don't have to review in you don't want to. This one was pretty trivial, but happy to hear any input you have. |
dhermes
reviewed
Oct 13, 2018
| if is_external_tool: | ||
| if external == "error": | ||
| logger.error( | ||
| "Error: {} is not installed into the virtualenv, it located at {}. " |
There was a problem hiding this comment.
it located -> it is located
There was a problem hiding this comment.
Good catch, 1646e52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --warn-on-external-run flag and the "external" keyword arg to session.run.
Closes #130