Run sessions in the same order specified on the command line. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Oct 17, 2018
| if (x.name in specified_sessions or set(x.signatures) & specified_sessions) | ||
| ] | ||
| queue = [] | ||
| for session_name in specified_sessions: |
There was a problem hiding this comment.
Don't you still want a set() for specified_sessions?
You could instead do an "ordered set":
>>> import collections
>>> specified_sessions = ["a", "c", "a", "c", "a", "b"]
>>> o_set = collections.OrderedDict((val, i) for i, val in enumerate(specified_sessions))
>>> list(o_set.keys())
['a', 'c', 'b']
>>> "d" in o_set
False
>>> "a" in o_set
TrueThere was a problem hiding this comment.
Eh, I'm not overly concerned. If someone really wants to specify a session twice we'll run it twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150