Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing a friendlier CLI name to sessions. #170

Merged
merged 4 commits into from
May 13, 2019
Merged

Allow providing a friendlier CLI name to sessions. #170

merged 4 commits into from
May 13, 2019

Conversation

s0undt3ch
Copy link
Contributor

import nox

@nox.session
def a_bar(session):
    pass

@nox.session(name="not-a-bar")
def not_a_bar(session):
    pass
$ nox -l
Available sessions:
* a_bar
* not-a-bar

@stsewd
Copy link
Collaborator

stsewd commented Feb 20, 2019

I like this idea, maybe a test case with a name with spaces?

@s0undt3ch
Copy link
Contributor Author

Sure.

@s0undt3ch
Copy link
Contributor Author

Though, that's not CLI friendly, but that's besides your observation 😄

@s0undt3ch
Copy link
Contributor Author

Done.

@s0undt3ch
Copy link
Contributor Author

So is this a go? Or a no go?

/cc @theacodes

@theacodes
Copy link
Collaborator

Looks good, but has conflicts, can you rebase?

@s0undt3ch
Copy link
Contributor Author

Bummer. Sure.

```python
import nox

@nox.session
def a_bar(session):
    pass

@nox.session(name="not-a-bar")
def not_a_bar(session):
    pass
```

```
$ nox -l
Available sessions:
* a_bar
* not-a-bar
```
@s0undt3ch
Copy link
Contributor Author

Done.

@theacodes theacodes merged commit 2903afc into wntrblm:master May 13, 2019
@theacodes
Copy link
Collaborator

Thank you, thank you, @s0undt3ch! ✨

@s0undt3ch s0undt3ch deleted the features/session-names branch May 13, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants