add type hints to tasks.py

[cs01]

Generate type hints database from types used during runtime:

pip install monkeytype
monkeytype run nox -s tests-3.6

See modules that can have types applied:

monkeytype list-modules

Apply types

monkeytype apply <module>

This exposed a circular dependency between session.py and manifest.py which was resolved in this PR. It ended up causing many LOC to be changed, but the change was cut+pasting code.

There are still several modules that haven't had types added yet since this PR got quite large.

Note that there are no type errors, unit tests did not change, and test coverage is still 100%.

[theacodes]

This is great, but we should try to find a way to remove the circular dependency without splatting t he whole manifest module into sessions.

[dhermes]

should try to find a way to remove the circular dependency

Indeed. I'd sleep much easier if there was a PR dedicated to resolving the circular dependency totally distinct from this one.

@cs01 Generating type hints is very much appreciated!

[cs01]

Sounds good, I will do that in a different PR and then revisit this one.

[cs01]

Oh something else that came up that was kind of annoying was the import sorting errors. I ran isort on nox which auto-sorted things, but nox uses a flake8 sorting plugin which doesn't match the way isort does its sorting so nox -s lint failed. Is there a way to auto-sort things such that its flake8 linter is happy?

[theacodes]

honestly we can just disable flake8's import order checking.

…

On Mon, Aug 26, 2019 at 10:48 AM Chad Smith ***@***.***> wrote: Sounds good, I will do that in a different PR and then revisit this one. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#241>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB5I42QFDFJOZD664IDKZLQGQJOLANCNFSM4IPJUDLA> .

[cs01]

I created a new PR to update import order linting in #242. This PR depends on that one, so it should be reviewed first.

This PR has been reduced in scope to only add types to tasks.py. I decided I'll make one PR for each file to keep the review process manageable.

[cs01]

Merged master into this PR. Now the diff is much smaller and only affects types in tasks.py.

[theacodes]

Rad, thanks!