add types to _option_set.py #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Sep 6, 2019
nox/_options.py
Outdated
| global_config = parsed_args | ||
| module = load_nox_module(global_config) | ||
| manifest = discover_manifest(module, global_config) | ||
| filtered_manifest = filter_manifest(manifest, global_config) | ||
| if isinstance(filtered_manifest, int): # pragma: no cover |
There was a problem hiding this comment.
If this is never hit, we should just remove the branch.
There was a problem hiding this comment.
mypy complains that it might be an int, so it's there as a type refinement since filter_manifest can return an int. I can look into adding a test case to cover this line.
|
SG, thanks for doing this!
…On Fri, Sep 6, 2019 at 10:51 AM Chad Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nox/_options.py
<#249 (comment)>:
> global_config = parsed_args
module = load_nox_module(global_config)
manifest = discover_manifest(module, global_config)
filtered_manifest = filter_manifest(manifest, global_config)
+ if isinstance(filtered_manifest, int): # pragma: no cover
mypy complains that it might be an int, so it's there as a type refinement
since filter_manifest can return an int. I can look into adding a test
case to cover this line.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#249>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB5I47Z6LPXO7G7MPBVB3LQIKKCTANCNFSM4IUD4UHQ>
.
|
|
Thank you, @cs01! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
monkeytype apply nox._option_setthen added additional types as needed.