Prefer importlib.metadata for metadata loading. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Jan 30, 2020
| except ImportError: | ||
| import importlib_metadata as metadata | ||
| import importlib.metadata as metadata # type: ignore | ||
| except ImportError: # pragma: no cover |
There was a problem hiding this comment.
Out of curiosity, when would this branch get hit?
There was a problem hiding this comment.
On Python 3.7 or earlier.
|
Thanks for doing this @jaraco, I had one question before merging. |
|
Thanks so much for doing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.