Remove some type ignores #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's time I learnt how to install all the Conda versions on Windows. |
|
I just noticed this doesn't work on 3.5.0. I will fix this. |
|
Fixed the issue with 3.5.0 |
theacodes
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I have started work on #292. In this PR I have updated the code to be able to remove the
# type: ignorefrom 1.1, 1.2, 1.4, 1.5 and I have fixed an incorrect typing forProcessEnv.allowed_globals.Since 1.1 touches a lot of files and since 1.2 was a bit more complex than I originally thought, I've stopped here. The other changes should be fairly trivial.
This leaves 1.3, 1.6 and all of 2 to be done.