draft: --add-timestamp

[omry]

introducing an --add_timestamp flag and support for in in the logging system.

#289

[omry]

1. Looking for overall feedback (Is it okay to add the flag? is the log format okay? [I noticed it's missing nox> )
2. colorlog test is failing even though things are working. looks like some kind of interaction between colorlog and logcap.
   I can probably test it via a process exec or something if it's very important.

[omry]

Screen shots:

[omry]

@theacodes ping

[theacodes]

Looks like a great addition, one little comment.

[theacodes]

Looking for overall feedback (Is it okay to add the flag? is the log format okay? [I noticed it's missing nox> )

This is a great idea. I would definitely add the nox >, as it's important to be able to distinguish Nox's output from the output that programs called via run produce.

colorlog test is failing even though things are working. looks like some kind of interaction between colorlog and logcap.

We'll definitely wanna get that working, but I'm not a fan of using subprocess in tests unless its absolutely necessary.

[omry]

We'll definitely wanna get that working, but I'm not a fan of using subprocess in tests unless its absolutely necessary.

The problem I ran into was that for an unknown reason, asctime was not populated in the caplog record when using colorlog. but we are talking about an interaction between two third party libs (caplog and colorlib), through the somewhat complicated Python logging subsystem.

I already spent about an hour or two digging into it. I will give it another shot before resorting to process testing.

[omry]

responded to comments, except the test.
Upon further digging, I suspect custom log formatter are not fully supported by pytest caplog.

I see two options:

1. Drop the testing for timestamp+colorlog and keep the current test for non-colorlog mode.
   This is very visible so if it breaks we will hear about it.
2. Switch both test modes to process based testing (which can be fragile, given we are testing for the presence of a timestamp in the log output).

What do you think?

[theacodes]

Sorry for taking so long to get to this. Let's go with (1).

[omry]

Regular run

Run with timestamps

Run with timestamp and no color.

[omry]

I noticed that there is some cleanup to do:

1. blacken is not running and seems to be producing results different than black .. it should probably be removed from the noxfile.
2. docs/conf.py needs black formatting.

[theacodes]

Thanks!