Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR compliance #273

Merged
merged 5 commits into from Dec 16, 2018
Merged

GDPR compliance #273

merged 5 commits into from Dec 16, 2018

Conversation

k-nut
Copy link
Member

@k-nut k-nut commented Dec 1, 2018

This should make the website GDPR compliant by

  • Removing Piwik tracking (we can always add it back later if needed)
  • Adding the Datenschutzerklärung provided by okfn.de and linking to it from the main page

Fixes #270

Copy link
Member

@johnjohndoe johnjohndoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-nut Thank you for moving forward and your time investment. Here is my thoughts about the implementation.

  1. I personally do not see a reason for dropping Piwik. It is both uses by the okfn.de and the bundesregierung.de - why shouldn't we?
  2. With regards to the agreement of the user I think we should follow the common pattern which is used by bundesregierung.de (see my comment).
  3. I think we can also check if the Datenschutzerklärung texts by okfn.de and bundesregierung.de differ by large.

@k-nut
Copy link
Member Author

k-nut commented Dec 3, 2018

@johnjohndoe I think the most important thing here is to bring the website back online. We can add Piwik back in a next PR but for now I think that it is not critical to do so whereas we gain quite a lot by putting the website back out there.

@johnjohndoe
Copy link
Member

@k-nut I would very much like to bring the website online back again. But since my name is in the imprint I would love to see this happening in alignment with the law. The basic question for me is whether users need to actively opt-in before using the website or if an opt-out is fine. By "copying" what bundesregierung.de does I believe we are on the legal side.
Another option is to replace my name by the OKF in the imprint.

@stefangrotz
Copy link

stefangrotz commented Dec 3, 2018

I agree with k-nut, we should bring the webside online first and add piwik second. As long as we don't track, there is no problem with GDPR. Every day we wait will cost us users that won't come back after three or four tries.

EDIT: deleted misunderstanding about the name in the imprint

@k-nut
Copy link
Member Author

k-nut commented Dec 3, 2018 via email

@k-nut
Copy link
Member Author

k-nut commented Dec 16, 2018

I just force pushed a version that removes the commit which removed Piwik and adds a section describing Matomo to the data privacy policy. The policy also includes a link where users can opt out of the tracking.

I checked three more 'official' pages and they also do not show any popups regarding cookies, Matomo or other trackers and just mention it in their data privacy statement:

@johnjohndoe
Copy link
Member

Thanks @k-nut 👍 I will take a look.
I manually restarted the Travis CI jobs since they were hanging it seems.

Copy link
Member

@johnjohndoe johnjohndoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! I identified a few issues and prepared three commits for you to take a look and rebase two of them if you agree with my changes.

Further, is there any reason why you did not take the info.html page back online?

Feel free to rewrite my commits and force push your branch.


BTW: There is a typo in the branch name which is okay to leave like it is. Otherwise GitHub will create an new pull request because it does not recognize the branch renaming.

js/main.js Outdated Show resolved Hide resolved
impressum.html Outdated Show resolved Hide resolved
impressum.html Outdated Show resolved Hide resolved
impressum.html Outdated Show resolved Hide resolved
impressum.html Outdated Show resolved Hide resolved
@k-nut
Copy link
Member Author

k-nut commented Dec 16, 2018

@johnjohndoe looks good to me. Thanks for fixing the mistakes in there.
I simply forgot the info page but just pushed a new commit that reenables it.

@k-nut
Copy link
Member Author

k-nut commented Dec 16, 2018

slightly changed the order of the commits and squashed all Datenschutz related ones into one commit.

@johnjohndoe johnjohndoe merged commit bde3356 into master Dec 16, 2018
@johnjohndoe johnjohndoe deleted the gdrp-compliance branch December 16, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants