Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dark theme feature #70

Closed
wants to merge 9 commits into from

Conversation

AlanSyue
Copy link
Contributor

I'd like to add the feature which can change light or dark theme.

I use this repo to implement this feature
https://github.com/karl-run/react-dark-theme

Hope this feature can be merged, thank you

@wojtekmaj
Copy link
Owner

Hi @AlanSyue! Thanks, I think it's an excellent idea. I worked on it a little more and implemented this in #71. Most notably, dependency on react-dark-theme was removed - there was really no need to have it, and this added a bit of bloat to our bundle.

You'll be co-authored :) Thanks!

@wojtekmaj wojtekmaj closed this Oct 14, 2020
@AlanSyue
Copy link
Contributor Author

@wojtekmaj Thanks!

@AlanSyue
Copy link
Contributor Author

@wojtekmaj
I've participated in Hacktoberfest event, could you please added the label hacktoberfest-accepted to this PR?
Thanks a lot!

@wojtekmaj
Copy link
Owner

There you go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants