Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/log4net not working #79

Merged
merged 9 commits into from
Mar 10, 2020
Merged

Bugfix/log4net not working #79

merged 9 commits into from
Mar 10, 2020

Conversation

harrwiss
Copy link
Collaborator

@harrwiss harrwiss commented Mar 8, 2020

Tried to fix various issues with logging and build config after migration to nc31.

Issue: #20

@harrwiss harrwiss requested a review from wokhan March 8, 2020 17:22
@harrwiss
Copy link
Collaborator Author

harrwiss commented Mar 9, 2020

Hi @wokhan,
have created Common.XTests (xunit) as a replacement for Common.Tests and fixed a problem with the log4net showing the LogHelper name as a prefix in the output window.

Hope will have time to review and merge it soon.

Cheers.

Console.Tests/Console.Tests.csproj Show resolved Hide resolved
@wokhan wokhan merged commit 208d05d into master Mar 10, 2020
@harrwiss harrwiss deleted the bugfix/log4net-not-working branch March 10, 2020 18:54
harrwiss added a commit to harrwiss/WFN that referenced this pull request Mar 15, 2020
* Add trace,debug constants

* wokhan#20 Fix build config and remove unused Assembly.cs

* Migrate console.tests  to get them running again

* Fix debug out logging, new log4net config, allways log os info, remove verbose check for info level

* Fix remove logger prefix in output

* Migrate common.tests  to xunit test framework

* Remove Common.Tests project (old)

* Removed Common.Tests folder as well

* Renamed back Common.XTests to Common.Tests and deaktivated release build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants