Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon pads in footprints are not converted correctly #28

Closed
tianfeng33 opened this issue Mar 6, 2020 · 14 comments
Closed

Polygon pads in footprints are not converted correctly #28

tianfeng33 opened this issue Mar 6, 2020 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@tianfeng33
Copy link

Hi, Just reporting on an issues with the conversion. I seem to be missing pads and other things. There is a link to the json file on the git hub.
unknown (1)

image

Here is a link to the project

https://easyeda.com/tianfeng/triple-bypass-v2

Thanks for your work

@urish
Copy link
Collaborator

urish commented Mar 6, 2020

Thanks for reporting!

Can you please also provide a list of the missing pads/other issues that you found so we can look into them?

@tianfeng33
Copy link
Author

Sure there is a lot.
I would start with it looks like the ground plane didn't convert. No GND pad
All pads are circular instead of square.
r1-r4,r6,r22,c6,c7,c20 have no pads.
r,5,r7,r8,r10r,r18,r20,r27,r29,r30,r35,c4,c5,c12,c13, are missing the top pad. R11,r24,r25,r31,r31,r37,c3,c19 are missing the bottom.
Several of the 0603 resistors pads also appear to be different sizes.

@urish
Copy link
Collaborator

urish commented Mar 6, 2020

Yes, I can definitely see these issues now. I attach the source JSON file for reference, and will start opening separate issues for each kind of problem shortly.

issue-28.zip

@urish urish changed the title Only a partial conversion Polygon pads in footprints are not converted corretly Mar 6, 2020
@urish urish self-assigned this Mar 6, 2020
@urish urish added the bug Something isn't working label Mar 6, 2020
@urish urish changed the title Polygon pads in footprints are not converted corretly Polygon pads in footprints are not converted correctly Mar 6, 2020
@urish
Copy link
Collaborator

urish commented Mar 6, 2020

Most of the issues (all the resistors related issues) seem to be related to conversion of polygon-shaped pads, so I renamed the issue to reflect that.

urish added a commit that referenced this issue Mar 7, 2020
urish added a commit that referenced this issue Mar 7, 2020
@urish
Copy link
Collaborator

urish commented Mar 7, 2020

Hi @tianfeng33, can you please check again with the last version from master?

Most issues should be resolved now, except for the GND PAD, which should eventually be fixed once #26 will be done and merged.

@rattboi
Copy link

rattboi commented Mar 7, 2020

I just tried this via the new online converter and it looks to be the same as before. Will the online version track specific releases or HEAD?

@urish
Copy link
Collaborator

urish commented Mar 7, 2020

@rattboi the online version tracks the releases. I have just released the latest fixes as 1.7.0, so they should now be reflected there as well.

@tianfeng33
Copy link
Author

I took some time with this today and noticed an issue but I don;t know what is causing it. The problematic pads are converting as custom circular and not rectangle. They need to be rotated 180 and changed to rectangle to make them match the correct ones. I am still experiencing issues with some ground pads not attaching to the ground flood even though the net is gnd.

@urish
Copy link
Collaborator

urish commented Mar 17, 2020

Hi @tianfeng33, have you used the latest version (1.7.0)? If yes, can you please attach a screenshot highlighting the issues?

@tianfeng33
Copy link
Author

tianfeng33 commented Mar 17, 2020

image

the non labeled pad is normal

image

Then changed to this.

image

The GND issue might be related to my lack of familiarity with Kicad but everything circled in red is gnd net.

image

but only some of them are reading that attachment and creating a spoke to ground on a fill.

I went through and fixed the 30 or so pads that were importing incorrectly

@urish
Copy link
Collaborator

urish commented Mar 20, 2020

So here is the deal - it seems like these pads are defined as having a custom shape (polygon) in EasyEDA, and as such, we also convert them to custom shape pads in KiCad. It seems like KiCad can't connect pads with custom shape to the ground fill. I will see if we can automatically detect from the list of points that this looks like a rectangle, and emit a rectangle pad instead of a custom-shape pad.

urish added a commit that referenced this issue Mar 20, 2020
EasyEDA sometimes uses polygon pads, even through the shape is a reactangle.
Unfortunately, KiCad does not handle polygon pads well in ground zones.
Thus, as a workaround, we automatically detect polygon pads that form a rectangle, and convert them to a rectangular pad instead.
@urish
Copy link
Collaborator

urish commented Mar 20, 2020

Can you please check now, with version 1.7.1?

@tianfeng33
Copy link
Author

I checked the other day and forgot to update you. It is all working much better. Only one small issues left. The ground fill does not attach to the two pins on the tssop 14 footprint. I just connected them with traces. It is a very small thing but I thought I would mention it

@urish
Copy link
Collaborator

urish commented Mar 29, 2020

Thanks for the update @tianfeng33! The same happens on my end. The reason for this seems to be the minimum width of the Copper Zone, which is set to 0.254mm.

image

I tried changing it to 0.1mm, and it did the trick for all 3 pads:

image

@urish urish closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants