Fix some issues discovered when running ruby OpenSSL gem tests. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenroche5
force-pushed
the
ruby_fixes
branch
from
d2c20cb
to
ea95079
Compare
SparkiDev
approved these changes
Sep 27, 2022
- If length param to rand bytes function is 0, do nothing and return success. - In we_dh_compute_key_int, if DH_get0_priv_key returns NULL, error out. The lack of NULL check here was causing a seg fault. - Add support for the dh_paramgen_prime_len control string in DH code. - Receiving EVP_PKEY_CTRL_DH_PARAMGEN_GENERATOR should return an error, since we don't support setting the generator. - Add a DH control command unit test. - Move EVP_PKEY_CTRL_DH_PAD definition into openssl_bc.h so that unit tests have access to it. Add comment noting which OpenSSL version introduced this macro. See ZD #14805.
haydenroche5
force-pushed
the
ruby_fixes
branch
from
ea95079
to
55399ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ZD #14805.