[Bug]: SSL_get_verify_result regression with LE certificates introduced in 5.1.1-stable #4879
Assignees
Labels
Comments
|
We've upgraded WolfSSL library being used in OpenWrt from 4.8.1 to 5.1.1 and got following bug report openwrt/openwrt#9283, affected code: res = SSL_get_verify_result(ssl);
if (res != X509_V_OK) {
if (us->notify_verify_error)
us->notify_verify_error(us, res, X509_verify_cert_error_string(res));
return;
} |
|
BTW I've already tried to git bisect the issue, but it seems like the Git tree is unusable for that. |
|
Seems like commit 1b6b16c or 1acf906 by @julek-wolfssl touched the codepaths around |
|
100% tests passed, thanks! |
jow-
pushed a commit
to openwrt/openwrt
that referenced
this issue
Feb 22, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
jow-
pushed a commit
to openwrt/openwrt
that referenced
this issue
Feb 22, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> (cherry picked from commit b9251e3)
jow-
pushed a commit
to openwrt/openwrt
that referenced
this issue
Feb 22, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> (cherry picked from commit b9251e3) (cherry picked from commit b99d7ae)
Boos4721
pushed a commit
to Boos4721/openwrt
that referenced
this issue
Feb 23, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> Signed-off-by: boos4721 <3.1415926535boos@gmail.com>
Boos4721
pushed a commit
to Boos4721/openwrt
that referenced
this issue
Feb 23, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> Signed-off-by: boos4721 <3.1415926535boos@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this issue
Feb 23, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: openwrt#9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
Beginner-Go
pushed a commit
to coolsnowwolf/lede
that referenced
this issue
Feb 23, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
aiamadeus
pushed a commit
to immortalwrt/immortalwrt
that referenced
this issue
Feb 24, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
Boos4721
pushed a commit
to Boos4721/openwrt
that referenced
this issue
Feb 25, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> Signed-off-by: boos4721 <3.1415926535boos@gmail.com>
andyleadbetter
pushed a commit
to andyleadbetter/openwrt
that referenced
this issue
Feb 26, 2022
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: openwrt#9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
ArtelMike
pushed a commit
to ArtelMike/openwrt-1
that referenced
this issue
Jan 31, 2023
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: openwrt#9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> (cherry picked from commit 92fbb76)
aparcar
pushed a commit
to openwrt/uclient
that referenced
this issue
Feb 4, 2023
In order to prevent regressions like #9283, lets add runtime check against letsencrypt.org. References: openwrt/openwrt#9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
aparcar
pushed a commit
to openwrt/uclient
that referenced
this issue
Feb 4, 2023
In order to prevent regressions like #9283, lets add build and runtime testing of wolfSSL master and release branches into daily scheduled pipeline. References: openwrt/openwrt#9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz>
ohabu
pushed a commit
to ohabu/openwrt
that referenced
this issue
May 12, 2023
Backport fix for API breakage of SSL_get_verify_result() introduced in v5.1.1-stable. In v4.8.1-stable SSL_get_verify_result() used to return X509_V_OK when used on LE powered sites or other sites utilizing relaxed/alternative cert chain validation feature. After an update to v5.1.1-stable that API calls started returning X509_V_ERR_INVALID_CA error and thus rendered all such connection attempts imposible: $ docker run -it openwrt/rootfs:x86_64-21.02.2 sh -c "wget https://letsencrypt.org" Downloading 'https://letsencrypt.org' Connecting to 18.159.128.50:443 Connection error: Invalid SSL certificate Fixes: #9283 References: wolfSSL/wolfssl#4879 Signed-off-by: Petr Štetiar <ynezz@true.cz> (cherry picked from commit b9251e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Contact Details
ynezz@true.cz
Version
5.1.1-stable
Description
In
v4.8.1-stablewolfSSL_get_verify_result()used to returnX509_V_OKwhen used againsthttps://letsencrypt.orgsite. With update tov5.1.1-stableit now returns "unknown error number" (fromX509_verify_cert_error_string()) value39(X509_V_ERR_INVALID_CA).4.8.1 example/client behaviour:
5.1.1 example/client behaviour:
Reproduction steps
Working test case with 4.8.1:
Failing test case with 5.1.1:
Relevant log output
The text was updated successfully, but these errors were encountered: