Espressif updates to fix Apple Homekit SHA / SRP #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2024
dgarske
requested changes
May 13, 2024
| @@ -44,13 +44,31 @@ | |||
| #include <esp_types.h> | |||
| #include <esp_log.h> | |||
|
|
|||
| #ifndef _INTPTR_T_DECLARED | |||
There was a problem hiding this comment.
These normally come from stdint.h. Any reason not to use it?
There was a problem hiding this comment.
I should have left myself a reminder; I don't recall. You're correct. For the ESP32 ESP-IDF, this is defined in:
xtensa-esp-elf\xtensa-esp-elf\sys-include\sys\_stdint.h
The missing _INTPTR_T_DECLARED was encountered in one of the other environments such as Arduino, PlatformIO, possibly the ESP8266 RTOS SDK.
There's probably no harm in leaving this, but I can put it in a separate PR once I re-discover why I needed it.
dgarske
approved these changes
May 13, 2024
|
Retest this please |
dgarske
approved these changes
May 14, 2024
This was referenced May 15, 2024
This was referenced May 22, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Espressif updates to fix Apple Homekit SHA / SRP
This was referenced Jun 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the problems encountered for the ESP32-C2 as noted in #7210 (see #7210 (comment)).
In particular, the concurrent SHA calculations have been improved: both in a multi-threaded environment, as well as for multiple, different SHA calculations (e.g. multiple SHA256, and/or concurrent, ongoing SHA512 hash calculations, suc as those in the SRP)
See application & notes in AchimPieters/esp32-homekit-demo#3
Fixes zd# n/a
Testing
How did you test?
Exhaustively tested on 8 types of ESP32 flavors + ESP8288 using my test jig and the
wolfssl_testexample app for Espressif.Also tested on Apple iPhone 5c with the Apple Homekit app and confirmed working for:
A variety of other minor changes, comments, and various code cleanup.
Checklist