New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix Visual Studio builds for TLS 1.3 #943

Closed

jay wants to merge 1 commit into wolfSSL:master from jay:fix_vs_builds_for_tls13

Contributor

jay commented May 30, 2017 •

edited

Loading

Include tls13.c in Visual Studio project files.
Clean up mixed declarations.
Put guards around the CURVE25519 code in client example.

--

Disclaimer: Though this makes Visual Studio and mingw builds possible (only client example fix needed for mingw) from master with TLS 1.3 enabled, and all tests pass respectively, I have not actually tried anything real world with this.

Note these changes only make it possible to build with TLS 1.3 support, they do not enable it by default. In VS the equivalent of --enable-tls13 seems to be:

#define WC_RSA_PSS
#define WOLFSSL_TLS13
#define HAVE_TLS_EXTENSIONS
#define HAVE_FFDHE_2048
#define HAVE_HKDF


          build: Fix Visual Studio builds for TLS 1.3

3b4e34f

- Include tls13.c in Visual Studio project files.

- Clean up mixed declarations.

- Put guards around the CURVE25519 code in client example.

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

7 similar comments

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented May 30, 2017

Can one of the admins verify this patch?

Contributor Author

jay commented May 31, 2017

I have since tried some https websites but I get servers returning fatal ssl alert Bad Record MAC (20) on handshake. See these captures of using curl/curl@5340562 with fix_vs_builds_for_tls13 branch to connect to curl.haxx.se for example. No idea if TLS 1.3 is used there, I don't know if Wireshark can detect it.

curl 5340562 with wolfSSL fix_vs_builds_for_tls13 - captures of working and not working.zip

wolfSSL-Bot commented Jul 12, 2017

Can one of the admins verify this patch?

3 similar comments

wolfSSL-Bot commented Jul 13, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented Jul 13, 2017

Can one of the admins verify this patch?

wolfSSL-Bot commented Sep 1, 2017

Can one of the admins verify this patch?

Contributor

dgarske commented Dec 20, 2017

Jay, thanks for your work on this. Marking this as closed. The PR #1282 replaces this.

dgarske closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet