Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tini to runtime dependencies #24978

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Jul 26, 2024

They released this commit https://gitlab.com/gitlab-org/build/CNG/-/commit/19faab2afd6fbb1f4393d5379e0d881d7724bf7e in version 17.2 that enables /usr/bin/tini to use as an entrypoint by default for gitlab-base, so, lots of images that use the gitlab-base is failing due to that.

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

EyeCantCU
EyeCantCU previously approved these changes Jul 26, 2024
@EyeCantCU
Copy link
Member

Will sort out updates today. Let's get this out

@EyeCantCU EyeCantCU enabled auto-merge July 26, 2024 15:43
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
@EyeCantCU EyeCantCU merged commit 0c28d1a into wolfi-dev:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants