python-3.11/CVE-2024-7592 patch implementation #27288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will put out advisory with the updated CVE info |
xnox
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Why would we ship unreviewed backport ahead of cpython upstream shipping it for python3.11 for a low severity CVE? Or any other distro?
Risks being, unreproducible behaviour change not present in any other python 3.11 distribution.
Example status from Debian - https://security-tracker.debian.org/tracker/CVE-2024-7592
[bookworm] - python3.11 (Minor issue, wait until merged into 3.11 branch)
|
I agree with your points, the only way it would make sense would maybe be for a critical CVE approaching SLA. Here is the advisory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking in the git-checkout block causes a out of memory error as the buffer size is exceeded when pulling in the two massive branches of 3.11 and 3.12, instead of adding in the logic of increasing buffer size and the subsequent increased build time, I created a patch of the backported changes instead. The patch is identical between all python versions and has been merged in 3.13 and 3.12, the only reason this remains an open PR is the fact that it requires a special level of privilege to merge on these branches. All tests pass on 3.11 commit that will implement this eventually