Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more JDK deps, libxml2, perl-test-pod, perl-yaml-syck, libxslt, xmlto… #43

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

rawlingsj
Copy link
Member

…, libxau, xtrans

Signed-off-by: James Rawlings jrawlings@chainguard.dev

…, libxau, xtrans

Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
secfixes:
2.10.3-r0:
- CVE-2022-40303
- CVE-2022-40304
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? If we add a new package with a secfix for the same version we are publishing, should we include these here?
Also I've not included secfixes for previous versions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that seems fine

@rawlingsj
Copy link
Member Author

Sorry for the larger review. There was a few related to each other so figured it best to push together. I can push smaller or larger groups if preferred.

@rawlingsj
Copy link
Member Author

hmm CI just failed with an error I've not seen when testing

2022/10/20 21:27:23 melange (libxml2/x86_64): /usr/lib/gcc/x86_64-pc-linux-gnu/12.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /lib/../lib64/libz.a(crc32.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
2022/10/20 21:27:23 melange (libxml2/x86_64): /usr/lib/gcc/x86_64-pc-linux-gnu/12.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: failed to set dynamic section sizes: bad value

@rawlingsj
Copy link
Member Author

specifically the error recompile with -fPIC

I'm not sure if that's the result of something I've missed from this PR or if it's a valid problem?

@rawlingsj
Copy link
Member Author

tried a change but it didn't help so reverted back to the original commit + issue

@kaniini
Copy link
Collaborator

kaniini commented Oct 20, 2022

It's because libxml2 build system has decided it wants to staticly link zlib in. I split out the zlib static library into its own package, to help give the libxml2 build system an attitude adjustment.

@kaniini
Copy link
Collaborator

kaniini commented Oct 20, 2022

GNOME appears to have recut the libxslt release since you wrote libxslt.yaml: 2022/10/20 23:01:02 melange (libxslt/x86_64): sha256sum: WARNING: 1 of 1 computed checksums did NOT match

Sigh.

Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
@rawlingsj
Copy link
Member Author

It's because libxml2 build system has decided it wants to staticly link zlib in. I split out the zlib static library into its own package, to help give the libxml2 build system an attitude adjustment.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants