resolves #1 #2
Open
resolves #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It takes a bit time for me to find a suitable time slot to check this case! By quickly glancing it over I'd say the solution is a bit against the philosophy I think we should go forward with. I'm thinking about alternative solutions to this. Are you in a hurry with this PR or can you use a workaround meanwhile? |
|
We went with this because it doesnt require and changes in the original autoloader, so we can have redux-autoloader without fork and only have the extra file in our project. So we are not at all in a hurry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple solution for what we need. It create two new HOCs, one for remembering names and refresh functions, one for wrapping the reload button. I've added info to readme but I didn't provide any tests. So it is up for everyone to complete.