Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Problems with DisableAutosave() and IncreaseQuickSaves() #16

Closed
Nicofisi opened this issue Jan 4, 2021 · 6 comments
Closed

Problems with DisableAutosave() and IncreaseQuickSaves() #16

Nicofisi opened this issue Jan 4, 2021 · 6 comments

Comments

@Nicofisi
Copy link

Nicofisi commented Jan 4, 2021

Hello!

Saves.DisableAutosave()

GameOptions.SetFloat("SaveConfig", "AutoSaveEnabled", false)

Is this expected to work? Because it doesn't for me, the command errors, from what I can see it should be SetBool

Saves.IncreaseQuicksaves()

GameOptions.SetInt("SaveSlotsConfig", "NumQuickSaveSlots", 10)

Same here, has someone tested whether this works? It errors for me as there is no such thing as SaveSlotsConfig, there is only Developer/SaveSlotsConfig as can be seen here:

Developer/SaveSlotsConfig/NumQuickSaveSlots = 3

I tried running GameOptions.SetInt("Developer/SaveSlotsConfig", "NumQuickSaveSlots", 10) and it showed as success, I also tried adding it to the autoexec.lua, but after reloading the game, the value is set, but pressing f5 still only keeps using slots 0 1 2, not more. Any ideas?

@Nicofisi
Copy link
Author

Nicofisi commented Jan 4, 2021

Visual.Rain(state)

It will probably be the same issue here:

GameOptions.SetFloat("FeatureToggles", "RainMap", true)

  • it is Developer/FeatureToggles
  • it is a Bool, not a Float

@kristoferblack
Copy link
Collaborator

@Nicofisi Let me do some testing on this. Could have just been a result of a bad copy/paste somewhere. Stay tuned

@Nicofisi
Copy link
Author

Nicofisi commented Jan 4, 2021

Interestingly enough I've just added a new file - C:\Program Files (x86)\GOG Galaxy\Games\Cyberpunk 2077\engine\config\platform\pc\myini.ini, and put this inside:

[Developer/SaveSlotsConfig]
NumQuickSaveSlots=10

now the new save slots work. It didn't work though when I used the autoexec.lua file to execute the command, as I stated above.

It probably means that the number is read intro some variable by the game engine before the autoexec file is executed by cyber-engine-tweaks? That's a little unfortunate

obraz

@kristoferblack
Copy link
Collaborator

Okay here's an update. You were right. These functions weren't being called to set the correct types. I fixed and tested them, so they will be included in the next release of the mod. Thanks for catching this!

That trick adding an INI for the save options is smart, I'll add that to the Wiki for others. And yeah, its likely the game reads it from somewhere in memory and sets it accordingly, possibly repeatedly. The INI method seems to become the source of truth for that value if it exists in there. I'm betting the same would work for AutoSavePeriod and AutoSaveEnabled.

@kristoferblack
Copy link
Collaborator

What you want is GameOptions.SetBool("FeatureToggles", "RainMap", true).

That doesn't actually make it rain. I think it toggles whether rain is rendered or not. So if you set it to false, presumably it wouldn't rain ever. Not sure tho.

@osulli
Copy link
Collaborator

osulli commented Jan 4, 2021

That's correct, it feature toggles rain. Not 'rainNow', just 'can it ever rain'.

And thanks for fixing the janky type :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants