This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
[FRNT-536, FRNT-435] Rewrite Button on box model #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatinacher
force-pushed
the
fix/FRNT-536-rewrite-button-on-box-model
branch
from
6762c05
to
3701b5b
Compare
sergeysova
suggested changes
May 7, 2021
Comment on lines
+9
to
+13
| button { | ||
| padding: 0; | ||
| margin: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Лучше не добавлять глобальные стили, ведь тогда не получится встроить библиотеку компонентов в сущетсвующий проект, ведь можем спокойно получить конфликт стилей
| @@ -40,10 +41,11 @@ export const Button = styled(ButtonBase)` | |||
| --local-shape-color: var(--woly-shape-default); | |||
| --local-border-color: var(--woly-shape-default); | |||
|
|
|||
| ${box}; | |||
There was a problem hiding this comment.
Почему бы не удалить переменные local-vertical, gap, compensate из компонента?
Irinaristova
reviewed
May 7, 2021
| @@ -6,6 +6,11 @@ export const Global = styled.div` | |||
| font-family: 'Helvetica Neue', sans-serif; | |||
| } | |||
|
|
|||
| button { | |||
There was a problem hiding this comment.
а мы здесь будем сброс стилей описывать для компонентов?
| ); | ||
| --local-gap: calc(1px * var(--woly-component-level) * var(--woly-main-level)); | ||
| --local-compensate: var(--local-vertical); | ||
| & > * { |
There was a problem hiding this comment.
мб стоит отступы между блоками делами делать? читать не очень
| @@ -40,10 +41,11 @@ export const Button = styled(ButtonBase)` | |||
| --local-shape-color: var(--woly-shape-default); | |||
| --local-border-color: var(--woly-shape-default); | |||
|
|
|||
| ${box}; | |||
|
|
|||
| box-sizing: border-box; | |||
| display: flex; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Мне кажется, было бы хорошо делать примеры с самими мелкими элементами, т.к. они чаще всего будут вложенными и на них будет ломаться box model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite Button on box model