Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

[FRNT-504] add spec for link #133

Closed
wants to merge 5 commits into from

Conversation

Irinaristova
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the @atoms Changes inside atoms label Jun 7, 2021
Copy link
Member

@sergeysova sergeysova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Irinaristova похоже, что ты случайно создала ветку от ветки с кнопкой. Попробуй сделать ветку заново, а коммит со спекой ссылки просто черрипикнуть в новую ветку и затем forcepush сюда ж, чтобы не пересоздавать ПР

Copy link
Contributor

@ainursharaev ainursharaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно немного отполировать, в целом хорошо

src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/button/button-spec.mdx Show resolved Hide resolved
src/ui/atoms/button/button-spec.mdx Show resolved Hide resolved
src/ui/atoms/button/button-spec.mdx Show resolved Hide resolved
src/ui/atoms/button/button-spec.mdx Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
Copy link
Member

@tatinacher tatinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот ПР ломает доку, потому что сейчас, если у mdx файла нет категории (как в спецификации), то выбрасывается Error.
Нужно либо временно прописать категорию файлу, либо временно заблокировать мерж ПР пока не доработаем тему

src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
src/ui/atoms/link/link-spec.mdx Outdated Show resolved Hide resolved
ainursharaev
ainursharaev previously approved these changes Jun 11, 2021
@ainursharaev ainursharaev dismissed their stale review June 11, 2021 08:51

Перепроверка

@tatinacher tatinacher marked this pull request as draft June 16, 2021 15:22
@tatinacher
Copy link
Member

Перевела в драфт, пока не смержим дубль этого ПР, потом этот ПР можно закрыть без мержа

@@ -0,0 +1,48 @@
`Кнопка` (html тег `<button>` ) — это функциональный элемент, то есть элемент, отвечающий за выполнение определённой функции, действия.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переименуй файл в specification.mdx плиз

@@ -0,0 +1,102 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Аналогично и тут specification.mdx

Не стоит дублировать имя компонента в имени файла

Copy link
Member

@sergeysova sergeysova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 

@Irinaristova
Copy link
Contributor Author

via [FRNT-504]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@atoms Changes inside atoms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants