This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
Add molecule inputPassword
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatinacher
force-pushed
the
feat/RBL-264-input-password
branch
from
fa6cbec
to
570bd1b
Compare
sergeysova
suggested changes
Sep 1, 2020
| import * as React from 'react'; | ||
| import styled, { StyledComponent } from 'styled-components'; | ||
|
|
||
| import * as input from '../../atoms/input'; |
There was a problem hiding this comment.
Suggested change
| import * as input from '../../atoms/input'; | |
| import { input } from '../../atoms'; |
| isHidden: boolean; | ||
| name: string; | ||
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => unknown; | ||
| onIconClick: React.MouseEventHandler<HTMLButtonElement>; |
There was a problem hiding this comment.
Здесь не нужен onIconClick, клик по иконке-глазу должен скрывать и показывать пароль автоматически
| iconOpen: React.ReactNode; | ||
| isHidden: boolean; | ||
| name: string; | ||
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => unknown; |
There was a problem hiding this comment.
Suggested change
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => unknown; | |
| onChange: React.ChangeEventHandler<HTMLInputElement>; |
| disabled?: boolean; | ||
| iconHidden: React.ReactNode; | ||
| iconOpen: React.ReactNode; | ||
| isHidden: boolean; |
There was a problem hiding this comment.
Это должно быть внутреннее состояние
| interface InputPasswordProps { | ||
| disabled?: boolean; | ||
| iconHidden: React.ReactNode; | ||
| iconOpen: React.ReactNode; |
There was a problem hiding this comment.
Пусть iconOpen и iconHide будут опциональными, по умолчанию задай им иконки
tatinacher
force-pushed
the
feat/RBL-264-input-password
branch
2 times, most recently
from
7f79f1c
to
1d1f519
Compare
sergeysova
force-pushed
the
feat/RBL-264-input-password
branch
from
1d1f519
to
1fc2263
Compare
sergeysova
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement inputPassword molecule