Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

[FRNT-345] Rewrite Select to div instead of input, and fix paddings #61

Merged
merged 1 commit into from
Apr 8, 2021
Merged

[FRNT-345] Rewrite Select to div instead of input, and fix paddings #61

merged 1 commit into from
Apr 8, 2021

Conversation

tatinacher
Copy link
Member

@tatinacher tatinacher marked this pull request as draft March 26, 2021 15:58
@github-actions github-actions bot added @atoms Changes inside atoms lib labels Mar 26, 2021
@tatinacher tatinacher marked this pull request as ready for review March 29, 2021 08:01
Irinaristova
Irinaristova reviewed Mar 29, 2021
View reviewed changes
src/lib/keyboard-event.ts Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Show resolved Hide resolved
src/ui/molecules/select/index.tsx Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/example.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/example.tsx Outdated Show resolved Hide resolved
sergeysova
sergeysova suggested changes Mar 29, 2021
View reviewed changes
src/lib/box-styles.tsx Outdated Show resolved Hide resolved
src/lib/keyboard-event.ts Outdated Show resolved Hide resolved
src/lib/keyboard-event.ts Outdated Show resolved Hide resolved
src/ui/molecules/select/example.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Show resolved Hide resolved
src/ui/molecules/select/index.tsx Show resolved Hide resolved
@sergeysova sergeysova self-requested a review April 2, 2021 09:28
@tatinacher tatinacher marked this pull request as draft April 2, 2021 14:58
@tatinacher tatinacher force-pushed the feat/FRNT-345-fix-select branch 3 times, most recently from 1a8ac85 to a216e62 Compare April 6, 2021 13:12
@tatinacher tatinacher marked this pull request as ready for review April 6, 2021 13:12
sergeysova
sergeysova suggested changes Apr 6, 2021
View reviewed changes
src/ui/molecules/select/usage.mdx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/example.tsx Outdated Show resolved Hide resolved
src/ui/molecules/select/index.tsx Outdated Show resolved Hide resolved
@sergeysova sergeysova self-requested a review April 7, 2021 09:52
@sergeysova sergeysova marked this pull request as draft April 7, 2021 09:56
@sergeysova sergeysova changed the title [FRNT-345] fix select [FRNT-345] Rewrite Select to div instead of input, and fix paddings Apr 7, 2021
@tatinacher tatinacher marked this pull request as ready for review April 7, 2021 16:35
@sergeysova sergeysova merged commit 1d6ec50 into master Apr 8, 2021
@sergeysova sergeysova deleted the feat/FRNT-345-fix-select branch April 8, 2021 08:46
@sergeysova sergeysova removed @atoms Changes inside atoms lib labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergeysova sergeysova sergeysova approved these changes

@Irinaristova Irinaristova Awaiting requested review from Irinaristova

Assignees
No one assigned
Labels
@molecules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tatinacher @sergeysova @Irinaristova