-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin-e2e-tests
#983
Add admin-e2e-tests
#983
Conversation
to make sure our plugin does not break WooCommerce Admin. Add `@woocommerce/admin-e2e-tests` dependency, clone test suites from https://github.com/woocommerce/woocommerce/tree/trunk/tests/e2e/specs as suggested in the release post (pcShBQ-6A-p2).
The tests fail due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomalec This looks fine to me. They tested great locally. We have an issue to investigate why the analytics overview tests fail in some Mac environments.
Analytics pages
✓ a user should see 3 sections by default - Performance, Charts, and Leaderboards (110ms)
✓ should allow a user to remove a section (153ms)
✕ should allow a user to add a section back in (548ms)
moving sections
✓ should not display move up for the top, or move down for the bottom section (139ms)
✕ should allow a user to move a section down (521ms)
✕ should allow a user to move a section up (30011ms)
Thank you @rrennick ! Now, there is a question for the Woogle team. Those tests require 5.6, but we are quite behind: * WC requires at least: 5.2
* WC tested up to: 5.5
Currently, we are not running E2E on CI, so broken tests would not block anything. |
I think we would need to test and bump it up one day. Latest version of WooCommerce is 5.6.0 released about two weeks ago, so we should bump it to the following ("at least" version is L-2):
I think we would need to take the "lowest common denominator" approach (see previous related Slack thread in our team channel p1629975717010800/1629914514.272300-slack-CK365S85V) and make sure things work with L-2 version, so we probably shouldn't merge it now, but later when "at least" version becomes 5.6.0. |
I find it funky.
And from the results of the tests, you can tell, that we did not break a thing, and our plugin is compatible with 5.6, but we cannot use it before we bump our minimal version to
It would be nice to have a package that once used would run the tests for a WC version against that version of WC. |
This PR, grown old, and rotten a bit, I'll try to redo it on the latest |
Our E2E tests no longer rely on the packages from WooCommerce as they are deprecated. We use wp-env now, see PR #2030 |
Changes proposed in this Pull Request:
Add
admin-e2e-tests
to make sure our plugin does not break WooCommerce Admin.
Add
@woocommerce/admin-e2e-tests
dependency,clone test suites from https://github.com/woocommerce/woocommerce/tree/trunk/tests/e2e/specs as suggested in the release post (pcShBQ-6A-p2).
It seems valuable, as we actually fail on two:
Screenshots:
Detailed test instructions:
Changelog entry