Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup to fix -actions build #90

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update rollup to fix -actions build #90

merged 2 commits into from
Nov 16, 2023

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Nov 14, 2023

Changes proposed in this Pull Request:

Currently, github actions build fails
due to not supported nullish coalescing assignment

Unexpected token '??='
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! woocommerce-grow-github-actions@1.10.1 build: `npx rollup -c`

This PR updates the rollup, and adds it explicitly as devDependnecy

I'm not updating to the latest 4.x, as it requires Node >18

Screenshots:

Detailed test instructions:

  cd ./packages/github-actions
  npm ci --ignore-scripts
  npm run build

Additional details:

Changelog entry

Fix - Github Actions build, update rollup to 3.29.4.

Older version fails with
`Unexpected token '??='`
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the build processing!

@tomalec tomalec merged commit 97ce16a into trunk Nov 16, 2023
1 check passed
@tomalec tomalec deleted the fix/gha-build branch November 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants