-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to wait for test completion when running tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongruige
reviewed
Feb 22, 2023
zhongruige
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding in this wait, this is a nice addition. I left a comment for a potential wording change, but it doesn't need to hold up this PR.
Co-authored-by: Greg <71906536+zhongruige@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows running a test in sync mode by passing the
--wait
flag.This is important if we want to allow users to delegate their testing execution to us in their own PRs, for instance.
How to test this:
23-01/results-iframe
./qit run:activation {foo} --wait
./qit list-tests
and see the last test IDmake enter
wp post meta update {TEST_ID} cd_status failed
echo $?
and assert that the exit status is1
success
echo $?
and assert that the exit status is0
warning
, which exits with a2
, and any other status is a3
.--json
as well.Unhappy paths:
./qit run:activation {foo} --wait --timeout=10
, see that the execution ends after the timeout is reached with a meaningful message informing that the test is still running, but we've reached the timeout for waiting for it.