Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: different Add to Cart Button color inside products grid blocks between editor and front end. #2066

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

dinhtungdu
Copy link
Member

Fixes #2065

On WP 6.1, the editor style is updated, which breaks the style of the Add to Cart Button inside products grid blocks like All Products or On Sale Products block. This PR fixes that issue by dynamically generating the style for Add to Cart Button using theme modifications.

Screenshots

Before After

How to test the changes in this Pull Request:

  1. Check and build this PR.
  2. Add All Products block to the page.
  3. See the color of add to cart button look as expected.
  4. Save the page, see the style of the button look the same between editor and front end.
  5. Use Customizer to change the text and background color of the button.
  6. See the color apply to both front end and editor.

Changelog

Fix - Ensure the style of the poducts grid Add to Cart button is consistent between the editor and front end.

Fix – Edit, reply and author icons are now displayed in comment list form. #1319

@dinhtungdu dinhtungdu self-assigned this Nov 8, 2022
@dinhtungdu dinhtungdu added type: bug The issue is a confirmed bug. status: needs review PR that needs review category: styles Issues related to styling editor Issues related to the editor styles labels Nov 8, 2022
@dinhtungdu dinhtungdu requested review from a team and gigitux and removed request for a team November 8, 2022 08:12
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@github-actions github-actions bot added status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. and removed status: needs review PR that needs review labels Nov 8, 2022
@dinhtungdu dinhtungdu merged commit 5aadfcb into trunk Nov 9, 2022
@dinhtungdu dinhtungdu deleted the fix/2065 branch November 9, 2022 01:45
@gigitux gigitux added this to the 4.2.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles Issues related to styling editor Issues related to the editor styles status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between back-end editor and front-end: buttons appear in black, while in back-end
2 participants