Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order detail: Incorrect handling of empty shipping & billing #298

Closed
nbradbury opened this issue Aug 9, 2018 · 3 comments · Fixed by #1161
Closed

Order detail: Incorrect handling of empty shipping & billing #298

nbradbury opened this issue Aug 9, 2018 · 3 comments · Fixed by #1161
Assignees
@anitaa1990
Labels
feature: order details Related to order details. type: enhancement A request for an enhancement.

Comments

@nbradbury
Copy link
Contributor

nbradbury commented Aug 9, 2018 •
edited
Loading

If an order has empty shipping & billing, we end up with an order detail like this:

screenshot_1533841508

You can repro this using order 896 in our test site.
@nbradbury nbradbury added the feature: order details Related to order details. label Aug 9, 2018
@mindgraffiti mindgraffiti mentioned this issue Aug 9, 2018
Closed
@AmandaRiu AmandaRiu added the needs: design Requires design input/work from a designer. label Aug 9, 2018
@AmandaRiu
Copy link
Contributor

We need some sort of design around what should be displayed here. Maybe something like "No shipping information available"? Added the label for "Needs design review"

@AmandaRiu
Copy link
Contributor

Per @folletto :

I think the idea of adding a “No address specified” as Amanda suggested is good, like in “Footnote” iOS / “Caption” Android, Woo Gray Text Min.

@folletto
Copy link

From design blueprint i6:

screen shot 2018-08-14 at 14 52 56

@rachelmcr rachelmcr added type: enhancement A request for an enhancement. and removed needs: design Requires design input/work from a designer. labels Mar 13, 2019
@mindgraffiti mindgraffiti mentioned this issue Mar 14, 2019
Closed
@anitaa1990 anitaa1990 mentioned this issue Jun 17, 2019
Merged
4 tasks
@anitaa1990 anitaa1990 self-assigned this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anitaa1990 anitaa1990

Labels
feature: order details Related to order details. type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Order detail: Incorrect handling of empty shipping & billing woocommerce/woocommerce-android
5 participants
@folletto @nbradbury @AmandaRiu @rachelmcr @anitaa1990