-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split PE - Add WooCommerce Pre-Order support for SEPA, iDEAL, Bancontact, Sofort purchases #2933
Conversation
…re-order that is charged upon release
return; | ||
} | ||
|
||
self::$has_attached_pre_order_integration_hooks = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are any possibility for this to fail, I would move the filter inclusion above this (so we can be sure the hook was attached).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think the risk is fairly low for this but happy to change the order of things here. I've changed it in: c643fa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #2780
Changes proposed in this Pull Request:
This PR fixes a number of issues I encountered when adding APM support for pre-orders.
This PR fixes all those issues.
Note
* This was partly fixed in #2911, however I was still experiencing that issue because
is_pre_order
wasn't being set to true here. I suspect it was because the original logic (maybe_process_pre_orders()
) checks if the order already has a saved payment method on it, I suspect it might have had a token saved earlier and that was leading the order to be processed.Testing instructions
Prerequisites
Pre Order charged upon release
add/deferred-intent
note 2 things:issue/2780
) and all available APMs should be listed.Pre Order charged upfront
changelog.txt
andreadme.txt
(or does not apply)Post merge