Implementing WordPress.com Authentication #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
added
status: do not merge
houndci-bot
reviewed
May 24, 2018
| return true | ||
| } | ||
|
|
||
| func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool { |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
jleandroperez
added
feature: login
|
Tested: (things not marked with a checkmark failed testing)
|
|
Magic link console error output |
|
Issue description updated: it should have never said Username (but instead Email, since username isn't really supported in this iteration!). Let's regroup on tuesday + debug the rest, thanks Thuy! |
Merged
|
Removed (username + password) as a failed test, since it's not applicable |
|
Bug fix verified. Merge whenever you're ready 🎉 |
|
Thank you Thuy!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR is the first stab at implementing WordPress.com authentication:
Testing:
We'd just need to run smoke tests over (all of the possible flows), and make sure the app doesn't crash. This is should cover all of the "Sign into WordPress.com" scenarios:
@mindgraffiti the PR itself looks HUGE (but i promise, it's mostly stubs!!!).