Implements Login Prologue #71
Conversation
| let defaultTextColor = UIColor.black | ||
| let sectionTitleColor = UIColor.darkGray | ||
| let buttonPrimaryColor = UIColor(red: 0x96/255.0, green: 0x58/255.0, blue: 0x8A/255.0, alpha: 0xFF/255.0) | ||
| let buttonPrimaryHighlightedColor = UIColor(red: 0x6E/255.0, green: 0x29/255.0, blue: 0x67/255.0, alpha:0xFF/255.0) |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
|
|
||
| /// WooCommerce UIImage Assets | ||
| /// | ||
| extension UIImage { |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
|
What does it look like? |
|
@nheagy not ready yet! i need to bug Davide with few metrics, but currently, looks like this on the iPhone SE: (adding the Shadow on top of the bottom white view right now)
|
|
Cool! |
|
Thank you @nheagy, work in progress actually!! 😄 |
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
A small bugfix and then 
sir :)
| @IBOutlet var loginButton: UIButton! | ||
|
|
||
|
|
||
| // MARK: - Overriden Properties |
There was a problem hiding this comment.
Overridden instead of Overriden
There was a problem hiding this comment.
MY GOD i may have been misspelling that forever!! thank you Thuy!!!
| } | ||
|
|
||
|
|
||
| // MARK: - Overriden Methods |
|
|
||
| /// Opens SafariViewController at the specified URL. | ||
| /// | ||
| func displaySafariViewController(at url: URL) { |
There was a problem hiding this comment.
Because of our AppDelegate settings, the Safari VC gets a white status bar. To fix it, add this:
extension SFSafariViewController {
override open func viewWillAppear(_ animated: Bool) {
super.viewWillAppear(true)
UIApplication.shared.statusBarStyle = .default
}
override open func viewWillDisappear(_ animated: Bool) {
super.viewWillDisappear(true)
UIApplication.shared.statusBarStyle = .lightContent
}
}
There was a problem hiding this comment.
Thank you for bringing this up!! i've, instead, added SafariViewController (SFSafariViewController subclass), that would give us extra flexibility (just a few LOC's).
Details:
Testing:
NOTE: Let's update the asset in another PR when it's ready!
cc @mindgraffiti