Login Epilogue: Mark I #72
Conversation
|
|
||
| static var defaultTextColor: UIColor { | ||
| return active.defaultTextColor | ||
| static var tableViewBackgroundColor: UIColor { |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
| /// White-Background View, to be placed surrounding the bottom area. | ||
| /// | ||
| @IBOutlet private var backgroundView: UIView! { | ||
| didSet { |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
|
|
||
| static var buttonPrimaryColor: UIColor { | ||
| return active.buttonPrimaryColor | ||
| static var tableViewBackgroundColor: UIColor { |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
mindgraffiti
modified the milestones:
Internal alpha release,
External closed beta group
| } | ||
|
|
||
| func downloadGravatarImage() { | ||
| guard let targetURL = StoresManager.shared.sessionManager.defaultAccount?.gravatarUrl, let gravatarURL = URL(string: targetURL) else { |
There was a problem hiding this comment.
| Opening braces should be preceded by a single space and on the same line as the declaration. |
|
|
||
| /// AccountHeaderView: Displays an Account's Details: [Gravatar + Name + Username] | ||
| /// | ||
| class AccountHeaderView: UIView { |
There was a problem hiding this comment.
| Opening braces should be preceded by a single space and on the same line as the declaration. |
Generated by 🚫 Danger |
| set { | ||
| fullnameLabel.text = newValue | ||
| } | ||
| get { |
There was a problem hiding this comment.
| Opening braces should be preceded by a single space and on the same line as the declaration. |
jleandroperez
added
feature: login
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
Unit tests ✅
Looking good @jleandroperez! Some nitpicky items then 
| /// | ||
| @IBOutlet private var noResultsLabel: UILabel! { | ||
| didSet { | ||
| noResultsLabel.font = UIFont.font(forStyle: .subheadline, weight: .regular) |
|
|
||
|
|
||
|
|
||
| // MARK: - Overriden Methods |
There was a problem hiding this comment.
Overridden instead of Overriden
There was a problem hiding this comment.
My GOD you must have sent me that comment 99 times already. SORRY about making the same mistake over and over!!!!
| return | ||
| } | ||
|
|
||
| headerView.username = "@" + defaultAccount.username |
There was a problem hiding this comment.
It would be nice to have a tiny convenience method (maybe in defaultAccount?) that added the @ symbol to a username string, because we'll be using this a lot more in the future.
There was a problem hiding this comment.
Holding this one for a bit... because, honestly, i have no idea what to call this calculated getter, and everything sounds awful (all of it)!!!.
"Prefixed Username" ... "At Username"... "usernameForDisplay"
bummytime
left a comment
bummytime
left a comment
There was a problem hiding this comment.
Code looks good @jleandroperez. Unit tests are ✅.
One thing I will point out is that the EmptyStoresTableViewCell doesn't render well in landscape:
You may want to disable landscape on this screen like we do on WPiOS.
Your call if you want to address that 👆 in this PR or create a separate issue.
Other than that,
|
Thanks for the review @mindgraffiti + @bummytime !!!. Addressing the pendings (Rotation support) in a second PR, which is in the works. For the record, pendings are:
|
Details:
This PR implements the Login Epilogue UI: We'll display a Store Picker, which will allow the user(s) to select the active WooCommerce Store.
I'm splitting this PR in two, since i'm already approaching 586 LOC.
Ref. #90
cc @mindgraffiti @bummytime
Thanks in advance!!
Testing:
Verify that the Login Epilogue should show up. Note that at this stage, the Epilogue is expected to look as follows (no matter if you do have or do not have a Store setup). To be finished in a second PR.