Turn Cart change address link to button #47460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: enhancement
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
Hi @wavvves, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
wavvves
approved these changes
May 14, 2024
github-actions
bot
added
the
plugin: woocommerce
senadir
force-pushed
the
fix/turn-change-address-to-button
branch
from
befb8c8
to
3ce94e6
Compare
github-actions
bot
added
the
needs: analysis
alvarothomas
added
needs: external testing
thealexandrelara
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Turn Change address link to button * Add changefile(s) from automation for the following project(s): woocommerce-blocks * fix lint --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the Change address button on Cart into a button so that it's accessible.
Closes #43620
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Make sure "Change Address" button in Cart block is accessible.
Comment