-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render an aria-label for the initial mini cart html #48329
Conversation
Hi @wavvves, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! but be sure to add the missing changelog file before merging ;)
Changes proposed in this Pull Request:
This PR renders an aria-label attribute for the initial mini-cart html that gets rendered, before React kicks in and replaces it.
Closes #42289 .
How to test the changes in this Pull Request:
button
element has an 'aria-label' attribute that says "Cart"aria-label
property that says "Cart"