Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Editor: restore and fix E2E test that creates product variations #48725

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Jun 21, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes and restores the E2E that tests when creating product variations.

Closes #48689

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Running E2E tests locally

cd plugins/woocommerce
pnpm test:e2e-pw tests/e2e-pw/tests/merchant/products/block-editor/create-variable-product-block-editor.spec.js
pnpm exec playwright show-report tests/e2e-pw/test-results/playwright-report
image

Running with UI

In the same woocommerce folder:

pnpm test:e2e-pw tests/e2e-pw/tests/merchant/products/block-editor/create-variable-product-block-editor.spec.js --ui
Screen.Recording.2024-06-21.at.3.12.29.PM.mov

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@retrofox retrofox added focus: e2e tests Issues related to e2e tests team: Mothra WC Merchants activation and store management labels Jun 21, 2024
@retrofox retrofox requested review from lanej0 and octaedro June 21, 2024 14:17
@retrofox retrofox self-assigned this Jun 21, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 21, 2024
Copy link
Contributor

Hi @lanej0, @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@retrofox retrofox force-pushed the update/e2e-test-improve-add-variation-test branch from f8561b3 to b846931 Compare June 21, 2024 14:28
Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ran the tests 10 times locally and had no failures and things are looking good on CI. 👍🏼

@lanej0 lanej0 merged commit 0273910 into trunk Jun 21, 2024
17 checks passed
@lanej0 lanej0 deleted the update/e2e-test-improve-add-variation-test branch June 21, 2024 16:49
@github-actions github-actions bot added this to the 9.2.0 milestone Jun 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 21, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jun 24, 2024
thealexandrelara pushed a commit that referenced this pull request Jul 18, 2024
…ons (#48725)

* update test when creating product variations

* fix picking 50 value from page

* handle snackBar step properly

* enable the rest of tests

* changelog

* simplify. remove console.log lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra WC Merchants activation and store management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Editor: create/update E2E test to test adding new global attribute terms
3 participants