-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Editor: restore and fix E2E test that creates product variations #48725
Conversation
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
f8561b3
to
b846931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I ran the tests 10 times locally and had no failures and things are looking good on CI. 👍🏼
…ons (#48725) * update test when creating product variations * fix picking 50 value from page * handle snackBar step properly * enable the rest of tests * changelog * simplify. remove console.log lines
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes and restores the E2E that tests when creating product variations.
Closes #48689
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Running E2E tests locally
Running with UI
In the same woocommerce folder:
Screen.Recording.2024-06-21.at.3.12.29.PM.mov
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment