feat(woodpecker-server)!: add monitoring resources and other improvements

[genofire]

@pat-s please review this time faster.

#22

fix #21

---

some things already merged by #77

---

Changelog

BREAKING CHANGES

• split metrics.enabled and the PodMonitor deployment to prometheus.podmonitor.enabled
  • move metrics.interval to prometheus.podmonitor.interval

Features

• metrics port also on services
• prometheus.podmonitor.interval optional (for use global server value)
• prometheus.podmonitor.label for dedicated labels only on pod-monitor
• first prometheus rule with alerting (is there a worker)
• prepare to ship grafana-dashboard

Bugfixes

• allow usage of extraVolumeMounts without persistenceVolume.enabled (allow extraVolumeMounts without enabling default persistentVolume #97)

chore

• replace if with with
• use named ports in services
• remove metrics.path (user should not change that value)
• remove not used ingress.hosts.paths.backend from values.yaml

[pat-s]

Thanks! See comments inline.

A short intro/example in the README would be great - most know Prometheus but it would be good to a short bit of information what this chart actually provides after this PR.

And please remove charts/server/grafana_dashboards/.gitkeep - it seemed to have slipped in by accident?

[genofire]

charts/server/grafana_dashboards/.gitkeep was created, because otherwise git does not create this directory charts/server/grafana_dashboards/, because there are not yet any files inside.

Of course i could delete the support of grafana_dashboards (and prometheus-rules, because we did not have any dashboards (and rules) yet.

or i need

[genofire]

wow for the fast review (multiply times a day, my last just get a "please rebase" after four mouth).

i do not know, how you create / generate changelogs. It does not look like convention-commit based ... so i write some in the description.

[pat-s]

wow for the fast review (multiply times a day, my last just get a "please rebase" after four mouth).

I am just contributing since some months - I wasn't (really) active during your last PR.

i do not know, how you create / generate changelogs.

It's done automatically by a release bot - which scrapes the commit message/PR titles and merges them with the labels assigned.

But for this one we should add a upgrade changelog in the README - so it would be good to do it there, i.e. in README-main.md.gotmpl. It only needs to cover instructions for users - doesn't need to be a full changelog :) Just focus on this PR and the "breaking" changes.

[genofire]

So should i split this PR in several PRs to get a nice CHANGELOG like in my description.

[pat-s]

Can you please add a new section to the README (below "Versioning") as follows

## Upgrading

<details>

<summary>To 1.0.0</summary>

YOUR CONTENT HERE

</details>

and replace YOUR CONTENT HERE with the user-facing upgrade notes? That would be awesome. No need for another PR, can go in here.

No features, just what users need to change if they were already using parts of the old implementation. Features etc. go into the release changelog then.

[genofire]

done, i have also improve the with/if on a place in the agent (but not change any logic)

[pat-s]

Thanks! A few last comments:

• Please revert the version upgrades (they are done during the release and are also inconsistent in this PR)
• Please avoid force pushes for future PRs as this makes it hard to see what changed (I remember you did this also in other/previous PRs - it's quite uncommon to do so in a regular PR workflow)
• Please merge main cleanly, then the dind removal changes should not appear in the PR

Besides: thanks for contributing 👍

[genofire]

1. done
2. sorry, i understand your workflow (with squashing on merge) now
3. i use the main branch (looks like dind PR has not generate docs) ... should i go back in commits?

[pat-s]

Almost there :)

[pat-s]

Thanks again! 🚀

[genofire]

when does it released?

[pat-s]

When WP 2.0 gets released

[woodpecker-bot]

🎉 This PR is included in version 1.0.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀