Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depends_on #119

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix depends_on #119

merged 1 commit into from
Jan 1, 2024

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 requested a review from a team January 1, 2024 11:21
@qwerty287
Copy link
Contributor Author

I really would like to have a linting for this 😆

@@ -64,9 +64,6 @@ steps:

release-next:
image: woodpeckerci/plugin-docker-buildx:2.2.1
depends_on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it depend at least on vendor step?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry just merged 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should... I'll open a follow-up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #120

@anbraten anbraten merged commit 51bf05d into main Jan 1, 2024
2 checks passed
@anbraten anbraten deleted the fix-dep branch January 1, 2024 13:06
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 31, 2023
1 task
@woodpecker-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants