Add git safe.directory support

[pat-s]

fix #63

• Add support for git config safe.directory
• Enabled by default for the directory which is being cloned (imo this should be what users want/expect)
• Default is set to $CI_WORKSPACE but can be adjusted via env var PLUGIN_SAFE_DIRECTORY

Works for me with image pats22/plugin-git:2.0.13 (based on plugin-git:2.0.3)

+ git init -b main
Initialized empty Git repository in /woodpecker/src/gitea.<owner>.com/<owner>/<repo>/.git/
+ git config --global safe.directory /woodpecker/src/gitea.<owner>.com/<owner>/<repo>
+ git remote add origin https://gitea.<owner>.com/<owner>/<repo>.git

[lafriks]

LGTM but don't know if this will not break anything in local/ssh runners?

[pat-s]

LGTM but don't know if this will not break anything in local/ssh runners?

What could potentially break?

Btw, I noticed I am not the only one running into this issue though some might handle it silently: https://codeberg.org/forgejo/forgejo/src/branch/forgejo/.woodpecker/testing-amd64.yml#L53

[lafriks]

LGTM but don't know if this will not break anything in local/ssh runners?

What could potentially break?

Btw, I noticed I am not the only one running into this issue though some might handle it silently: https://codeberg.org/forgejo/forgejo/src/branch/forgejo/.woodpecker/testing-amd64.yml#L53

When multiple jobs run on the same host in parallel one will override others safedir.

[lafriks]

Maybe this could be changed to set the default safe directory only if it's not already set?

[6543]

@lafriks if it's not global set there is no race condition or change in the host config

[lafriks]

@lafriks if it's not global set there is no race condition or change in the host config

Yes, I did not notice that global is gone already ;)

[pat-s]

Is there anything left or is this ready to merge? :)

[pat-s]

@lafriks @6543 gentle ping :)

changes in code

[lafriks]

@6543 this will now conflict for parallel jobs on local/ssh instances

[6543]

it should not ... as git global config change should not create race conditions ...

[lafriks]

why not? as commands are run sequentially and if two pipelines are run at the same time it could be:

git config --global safe.directory /path/to/workspace1
git config --global safe.directory /path/to/workspace2
git clone workspace1
git clone workspace2

so there is a chance that only workspace2 pipeline will succeed

[anbraten]

Afaik safe.directory is an array, so maybe it will be added to it. Otherwise we could change it to use --add

[6543]

I'm for --add if it exist to be explicite

[lafriks]

As this is needed only for local/ssh I think it should be preconfigured to have safedir where all workspace directories will be created. It would be enough to check if safedir is set as parent dir for current workspace than not set it

[woodpecker-bot]

🎉 This PR is included in version 2.1.0 🎉

The release is now available [here]([object Object])

Thank you for your contribution. ❤️📦🚀