golang vendor dependencys once to not timeout #192
Conversation
|
Do we really need it for the |
|
YES |
|
that's why we get timeouts .... |
|
from ~25min down to 2 |
| commands: | ||
| - make test | ||
|
|
||
| build: | ||
| image: woodpeckerci/plugin-docker-buildx:4.0.0 | ||
| depends_on: [ lint, test ] | ||
| depends_on: [ lint, test, vendor ] |
There was a problem hiding this comment.
This does not seem needed as lint and test already depend no vendor
There was a problem hiding this comment.
yes but if in future we alter stuff ... that step do explizit need vendor too ... here it is a noop but the documentation porpuse stayews
well plugin-s3/Dockerfile.multiarch Lines 6 to 8 in 0903b1f should cache to some extend ... but it looks like it does not work in our case ...?!? |
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `1.2.1` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [1.2.1](https://github.com/woodpecker-ci/plugin-s3/releases/tag/v1.2.1) - 2024-06-19 ### 🐛 Bug Fixes - Fix typo in docker image names [[#194](#194)] - Update docs to reflect current pipeline config [[#188](#188)] ### Misc - Publish to docker hub only [[#195](#195)] - golang vendor dependencys once to not timeout [[#192](#192)] - Add nix flake [[#187](#187)] - fix(deps): update module github.com/aws/aws-sdk-go to v1.54.2 [[#189](#189)] - Fix remove dependency of "publish" workflow [[#190](#190)]
|
🎉 This PR is included in version 1.2.1 🎉 The release is now available here Thank you for your contribution. ❤️📦🚀 |
dont have timeouts like https://ci.woodpecker-ci.org/repos/6032/pipeline/975/5