Log flooded by done: cannot close log stream entries

[xoxys]

Component

server

Describe the bug

After a short period of time, I have already many of these entries in the log:

{"level":"error","repo_id":"4","pipeline_id":"73","workflow_id":"172","error":"stream: not found","time":"2023-07-25T21:31:12Z","message":"done: cannot close log stream for step 519"}
{"level":"error","repo_id":"4","pipeline_id":"73","workflow_id":"172","error":"stream: not found","time":"2023-07-25T21:31:12Z","message":"done: cannot close log stream for step 520"}

This one also occurs pretty often:

{"level":"warn","error":"sql: no rows in result set","time":"2023-07-25T21:29:56Z"}

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-1c116daf"}

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[6543]

The second error is a generic error the datastorge (db module) return, when an requested item was not found.

So to fix that we need more infobwhat the originated request was

[6543]

The first err got added by #1802 and jas just droped in tje past.

As it happens frequently, there is eiter an issue with either stream opening or it got closed before.

in any case we should dig into it.

Affected part: pubsub mod for live log streaming over eventstream

[xoxys]

The second one occurs every time a repo page is accessed that does not yet have a pipeline:

Refreshing this page multiple time will create the sql: no rows in result set log every time.

[6543]

Ah then its a easy fix ... will do so once i have a keboard on hand again

[6543]

I think we do have something like that:

woodpecker/server/api/pipeline.go

Line 148 in 1da0ad3

if errors.Is(err, types.RecordNotExist) {

(404 err handling) missing on a endpoint queryed by this view

[6543]

-> #2042

[6543]

also the generic error will get less generic -> #2041

[6543]

ok the first error is created here:

woodpecker/server/grpc/rpc.go

Lines 295 to 297 in 3033abc

	if err := s.logger.Close(c, step.ID); err != nil {
	logger.Error().Err(err).Msgf("done: cannot close log stream for step %d", step.ID)
	}

but the question is why!

[6543]

moved to bugfix version as it's non blocking :)

[catdevnull]

this also happens to me and the last few characters or things in the log for a pipeline disappear even though it shows itself as successful/errored