Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woodpecker-cli misnamed in RPM and DEB releases #2112

Closed
5 tasks done
inflatador opened this issue Aug 4, 2023 · 5 comments
Closed
5 tasks done

woodpecker-cli misnamed in RPM and DEB releases #2112

inflatador opened this issue Aug 4, 2023 · 5 comments
Labels
bug Something isn't working build CI pipeline related feedback this needs feedback

Comments

@inflatador
Copy link
Contributor

Component

cli

Describe the bug

woodpecker-cli's RPM and DEB packages install a binary called 'woodpecker' as opposed to 'woodpecker-cli'. The binary appears to work, but this is confusing as the examples (and tarball releases) use the name 'woodpecker-cli'.

System Info

Fedora 38 (RPM), Debian 11 (DEB)

Additional context

Fedora:

$sudo rpm -ivh https://github.com/woodpecker-ci/woodpecker/releases/download/v1.0.0/woodpecker-cli-1.0.0.x86_64.rpm
$rpm -ql woodpecker-cli
/usr/local/bin/woodpecker

Debian:

 $sudo dpkg -i woodpecker-cli_1.0.0_amd64.deb
Selecting previously unselected package woodpecker-cli.
$ dpkg -L woodpecker-cli
/usr
/usr/local
/usr/local/bin
/usr/local/bin/woodpecker

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@inflatador inflatador added the bug Something isn't working label Aug 4, 2023
@qwerty287
Copy link
Contributor

That's the intended name for the binary.

@inflatador
Copy link
Contributor Author

In that case, should I change the report to 'standardize woodpecker-cli binary name' or something like that?

@qwerty287
Copy link
Contributor

I think this is also intended to differentiate it from server and agent, but the binary itself should be called woodpecker (also see examples in user settings on your instance).

@6543 6543 added the build CI pipeline related label Aug 4, 2023
@6543
Copy link
Member

6543 commented Aug 4, 2023

binary currently should be:

woodpecker         # cli
woodpecker-server  # server
woodpecker-agent   # agent

as it's handy for autocompletion in shell, I would argue ... but if the package name also should just be called that way I dont know ...

@6543 6543 added the feedback this needs feedback label Aug 4, 2023
@qwerty287
Copy link
Contributor

I'll close this as there was no response and @6543 explained why it is called this way.
If you still have an issue with it please comment

@qwerty287 qwerty287 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
ambroisie added a commit to ambroisie/nixpkgs that referenced this issue Feb 10, 2024
The intended executable name is supposed to be `woodpecker`, not
`woodpecker-cli`, as pointed out in [1].

[1]: woodpecker-ci/woodpecker#2112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build CI pipeline related feedback this needs feedback
Projects
None yet
Development

No branches or pull requests

3 participants