Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AttributeHydratorInterface #29

Merged

Conversation

holtkamp
Copy link
Contributor

As suggested in #28 (comment)

@kocsismate
Copy link
Member

Oh, I now see what you meant! Looks really promising after a quick look, but I'll have a look at it in a couple of days!

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@40e6a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   97.91%           
  Complexity        ?      513           
=========================================
  Files             ?       29           
  Lines             ?     1056           
  Branches          ?        0           
=========================================
  Hits              ?     1034           
  Misses            ?       22           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e6a21...a836a26. Read the comment docs.

@kocsismate kocsismate merged commit 1e8ed9f into woohoolabs:master Apr 19, 2020
@kocsismate
Copy link
Member

@holtkamp Sorry for this taking a long time. I like your solution, so merged the PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants