perf: Improve performance by reducing redundant pynvml.nvmlInit call #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stonesjtu
approved these changes
Nov 24, 2023
Lots of time is spent on nvmlInit() and nvmlShutdown() for each new_query call. When running in a loop mode (-i), we do not need to initialize and shutdown the nvml library because nvml APIs will be used throughout the lifespan of the gpustat process. Upon importing `gpustat.pynvml`, nvmlInit() will always be called.
wookayin
force-pushed
the
improve-perf
branch
from
9c51ddf
to
313b58d
Compare
wookayin
changed the title
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: Call nvmlInit() and nvmlShutdown() only once (fixes #54)
Lots of time is spent on nvmlInit() and nvmlShutdown() for each
new_query call. When running in a loop mode (-i), we do not need to
initialize and shutdown the nvml library because nvml APIs will be used
throughout the lifespan of the gpustat process.
Upon importing
gpustat.pynvml, nvmlInit() will always be called.