Replace got w/ node-fetch
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
approved these changes
Mar 8, 2022
|
Can you rebase? I fixed the unrelated error on main |
ChristianMurphy
approved these changes
Mar 8, 2022
Comment on lines
+104
to
+110
| const cachedContents = cache.get(href) | ||
| if (cachedContents) { | ||
| contents = cachedContents | ||
| } else { | ||
| contents = await (await fetch(href)).text() | ||
| cache.set(href, contents) | ||
| } |
There was a problem hiding this comment.
This issue may have already existed before, but now is more visible.
It's a bit worrying that the caching system doesn't have memory management (max cached items, max memory usable, etc).
On massive projects, caching could become an issue exceeding the memory node is allowed.
There was a problem hiding this comment.
Yeah, not sure whether that should be improved as part of this PR though, might be better do to it in a separate PR?
There was a problem hiding this comment.
I’m not too worried about it. Could use something smarter in the future (an LRU cache?), but this is probably fine for now in build scripts
wooorm
approved these changes
Mar 9, 2022
wooorm
changed the title
got with Cloudflare-friendly alternativegot w/ node-fetch
|
Released, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #109. It replaces the
gotpackage which is only used once, with an alternative (node-fetch, which against intuitions does not depend on@types/nodewheregotdid ).This means that there are now not any issues when running
tscin a Cloudflare Workers project which usesxdm. This came up specifically while building a Remix application, as@remix-run/devdepends onxdm.I made sure to replicate the existing caching set up, as that is not included in
node-fetch.Thanks for this awesome project 🙏