Taxes ux #11860
Merged
Taxes ux #11860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If taxes are disabled in the “General settings tab”, then the “Tax” tab disappears, and the suffix can no longer be edited, but is still displayed in the store This fix makes sure that the suffix is only displayed if taxes are enabled
|
cc @mattyza |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If taxes are disabled in the “General settings tab”, then the “Tax” tab disappears, and the suffix can no longer be edited, but is still displayed in the store
http://cld.wthms.co/1idx3/16tEcXve
This fix makes sure that the suffix is only displayed if taxes are enabled