Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RequestRejectedException 핸들링 코드 추가 #788

Merged
merged 1 commit into from
Feb 6, 2022
Merged

fix: RequestRejectedException 핸들링 코드 추가 #788

merged 1 commit into from
Feb 6, 2022

Conversation

xrabcde
Copy link
Collaborator

@xrabcde xrabcde commented Feb 2, 2022

구현 기능

  • 그놈의 malicious String 때문에 DEV, PROD 가리지 않고 잉잉 우는 사이렌을 잠재우기 위해 해당 예외 잡아서 400으로 내리는 핸들링 코드를 추가했습니다.

image

before

스크린샷 2022-02-02 오후 7 47 36

after

requestrejectedexception3

공유하고 싶은 내용

  • 자세한 내용은 블로그에 정리했으니 참고하세요 '-'

Close #786

@xrabcde xrabcde added 🐛 bug Something isn't working 🕋 backend labels Feb 2, 2022
@xrabcde xrabcde self-assigned this Feb 2, 2022
dusdn1702
dusdn1702 approved these changes Feb 5, 2022
View reviewed changes
Copy link
Collaborator

@dusdn1702 dusdn1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다~

tributetothemoon
tributetothemoon approved these changes Feb 5, 2022
View reviewed changes
Copy link
Collaborator

@tributetothemoon tributetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀구우욷~~!

sakjung
sakjung approved these changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@sakjung sakjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 몰라서 그러는데,
RequestRejectedException 이 발생하는 다른 경우의 수가 존재할 수도 있을 것 같아서요.
그런 경우도 한꺼번에 싸잡아서 Bad Request 처리를 해버리는게 맞나 싶기는 하네요.

에러 메세지 파싱해서 Maclious String 으로 발생하는 RequestRejectedException만 Bad Request로 처리해주는게 더 합리적이지 않을까...라는 생각을 해봤습니다.

@xrabcde xrabcde merged commit 7c14352 into dev Feb 6, 2022
@xrabcde xrabcde deleted the fix/786-handle-malicious-string branch February 6, 2022 15:18
This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakjung sakjung sakjung approved these changes

@tributetothemoon tributetothemoon tributetothemoon approved these changes

@dusdn1702 dusdn1702 dusdn1702 approved these changes

Assignees

@xrabcde xrabcde

Labels
🕋 backend 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] RequestRejectedException 핸들링
4 participants
@xrabcde @dusdn1702 @tributetothemoon @sakjung