[럿고] 체스- 스프링 실습 2단계 제출합니다. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial Commit * refactor: DAO try - resource 적용 * refactor: BoardDAO.addPieces(), hasNotGameIn() 추가 * refactor: 방어적 복사 적용 * refactor: Name -> Symbol 변경, BoardFactory -> PiecesFactory 변경 * refactor: 세션 만료시간 추가 * refactor: post -> put method type 변경, ChessController api 분리
ddaaac
approved these changes
Apr 25, 2020
| return GSON.toJson(from + " " + to); | ||
| } | ||
|
|
||
| @ResponseStatus(value = HttpStatus.CONFLICT) |
| import wooteco.chess.domain.piece.Piece; | ||
| import wooteco.chess.domain.piece.PieceFactory; | ||
| import wooteco.chess.domain.piece.Symbol; | ||
| import wooteco.chess.domain.position.Column; | ||
| import wooteco.chess.domain.position.Position; | ||
|
|
||
| @Component | ||
| public class BoardDAO { | ||
| public void addPieces(String gameId, List<Piece> pieces) { | ||
| String query = "INSERT INTO board VALUES (?, ?, ?)"; |
There was a problem hiding this comment.
저는 쿼리문을 쓸 때 INSERT INTO board (id, name, symbol) VALUES (?, ?, ?) 처럼 컬럼명을 명시해주는 편입니다. 유지보수도 편해지고, 에러가 났을 때 인텔리제이의 지원도 받을 수도 있기 때문입니다(링크).
| import wooteco.chess.domain.piece.Team; | ||
|
|
||
| @Component |
| this.name = name; | ||
| this.position = position; | ||
| } | ||
|
|
||
| public Column plus() { | ||
| return Arrays.stream(Column.values()) |
There was a problem hiding this comment.
제가 생각했던 방식은 ordinal()을 사용해서 불필요한 stream까지 제거하는 방식이었습니다!
try {
return values()[ordinal() + STEP];
} catch (ArrayIndexOutOfBoundsException e) {
throw new IllegaArgumentException(...);
}
gracefulBrown
approved these changes
Apr 26, 2020
ksy90101
added a commit
to ksy90101/jwp-chess
that referenced
this pull request
Apr 30, 2020
* [코즈] 체스 - 스프링 실습 1단계 제출합니다. (woowacourse#15) * Initial Commit * refactor: DAO try - resource 적용 * refactor: BoardDAO.addPieces(), hasNotGameIn() 추가 * refactor: 방어적 복사 적용 * refactor: Name -> Symbol 변경, BoardFactory -> PiecesFactory 변경 * refactor: 세션 만료시간 추가 * refactor: post -> put method type 변경, ChessController api 분리 * refactor: rs.next NPE 대비, boardDAO.findAll() -> findAllPieces() 네이밍 변경 * refactor: position -> ordinal() 변경 * refactor: 메소드 분리 * docs: Spring 요구 사항 작성 * refactor: html -> hbs 변경, 미사용 테스트 제거 * refactor: SpringChessController.renderStart() 구현 * refactor: SparkChessController - game id, Session -> params 사용 * feat: SpringChessController.renderBoard() 구현 * feat: SpringChessController.updateBoard(), handleException() 구현 * feat: SpringChessController.renderResult() 구현 Co-authored-by: Gyeong-Jun Kim <lastpuzly@gmail.com> Co-authored-by: Seyun <ksy90101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
범블비 감사해요!